[Libguestfs] [nbdkit PATCH 0/9] common: catch up with libnbd

This is the counterpart series for [libnbd PATCH 0/6] common: catch up with nbdkit http://mid.mail-archive.com/20230301114027.336230-1-lersek@redhat.com Contrarily to my prognosis in that cover letter, this series does ultimately extend up to libnbd v1.15.11 in one go. As a result, once this series is merged, the common subdirs between libnbd @ d169661119f6 and nbdkit @ end-of-this-series will be in sync as much as reasonable. Laszlo Eric Blake (1): build: Silence some cppcheck warnings [partial port] Laszlo Ersek (6): use space consistently in function and function-like macro invocations common/include: add TYPE_IS_POINTER() macro common/include: extract STATIC_ASSERT() macro force semicolon after DEFINE_VECTOR_TYPE() macro invocations vector: introduce DEFINE_POINTER_VECTOR_TYPE() convert string_vector_(iter(free) + reset()) to string_vector_empty() Nir Soffer (1): common/utils/vector.h: Remove stale reference to `size` Richard W.M. Jones (1): common/include: Add a function to compute log2(unsigned long) Makefile.am | 1 + common/allocators/allocator-internal.h | 2 +- common/allocators/allocator.c | 2 +- common/allocators/allocator.h | 18 +- common/allocators/malloc.c | 4 +- common/allocators/sparse.c | 4 +- common/allocators/zstd.c | 4 +- common/bitmap/bitmap.c | 2 +- common/bitmap/bitmap.h | 16 +- common/gpt/efi-crc32.h | 2 +- common/include/Makefile.am | 1 + common/include/array-size.h | 2 +- common/include/byte-swapping.h | 24 +-- common/include/checked-overflow.h | 42 ++--- common/include/compiler-macros.h | 33 +++- common/include/ispowerof2.h | 13 ++ common/include/iszero.h | 2 +- common/include/minmax.h | 4 +- common/include/nextnonzero.h | 2 +- common/include/random.h | 4 +- common/include/static-assert.h | 48 +++++ common/include/test-array-size.c | 71 +++----- common/include/test-ispowerof2.c | 10 + common/include/test-random.c | 192 ++++++++++---------- common/protocol/nbd-protocol.h | 12 +- common/regions/regions.c | 2 +- common/regions/regions.h | 12 +- common/replacements/open_memstream.c | 4 +- common/replacements/strndup.c | 2 +- common/replacements/strndup.h | 2 +- common/utils/cleanup.h | 24 +-- common/utils/const-string-vector.h | 4 +- common/utils/environ.c | 3 +- common/utils/exit-with-parent.c | 6 +- common/utils/nbdkit-string.h | 4 +- common/utils/string-vector.h | 11 +- common/utils/test-vector.c | 7 +- common/utils/utils.c | 2 +- common/utils/utils.h | 2 +- common/utils/vector.h | 63 +++++-- configure.ac | 3 + filters/blocksize-policy/policy.c | 2 +- filters/blocksize/blocksize.c | 2 +- filters/cache/blk.h | 12 +- filters/cache/cache.c | 2 +- filters/cache/reclaim.c | 2 +- filters/checkwrite/checkwrite.c | 2 +- filters/cow/blk.h | 10 +- filters/cow/cow.c | 2 +- filters/ddrescue/ddrescue.c | 4 +- filters/delay/delay.c | 4 +- filters/error/error.c | 2 +- filters/exitlast/exitlast.c | 2 +- filters/exitwhen/exitwhen.c | 8 +- filters/exportname/exportname.c | 2 +- filters/ext2/ext2.c | 2 +- filters/ext2/io.h | 4 +- filters/extentlist/extentlist.c | 4 +- filters/fua/fua.c | 2 +- filters/gzip/gzip.c | 2 +- filters/ip/ip.c | 12 +- filters/limit/limit.c | 2 +- filters/log/log.c | 2 +- filters/log/log.h | 8 +- filters/luks/luks-encryption.c | 4 +- filters/luks/luks.c | 2 +- filters/multi-conn/multi-conn.c | 6 +- filters/nocache/nocache.c | 2 +- filters/noextents/noextents.c | 2 +- filters/nofilter/nofilter.c | 2 +- filters/noparallel/noparallel.c | 2 +- filters/nozero/nozero.c | 2 +- filters/offset/offset.c | 2 +- filters/partition/partition-gpt.c | 4 +- filters/partition/partition.c | 2 +- filters/pause/pause.c | 2 +- filters/protect/protect.c | 4 +- filters/rate/rate.c | 4 +- filters/readahead/readahead.c | 2 +- filters/readahead/readahead.h | 2 +- filters/retry-request/retry-request.c | 2 +- filters/retry/retry.c | 2 +- filters/scan/scan.c | 2 +- filters/scan/scan.h | 2 +- filters/swab/swab.c | 2 +- filters/tar/tar.c | 2 +- filters/tls-fallback/tls-fallback.c | 2 +- filters/truncate/truncate.c | 2 +- filters/xz/blkcache.h | 8 +- filters/xz/xz.c | 2 +- include/nbdkit-common.h | 16 +- plugins/blkio/blkio.c | 4 +- plugins/cc/cc.c | 4 +- plugins/cdi/cdi.c | 2 +- plugins/curl/curl.c | 6 +- plugins/curl/curldefs.h | 2 +- plugins/curl/pool.c | 2 +- plugins/data/data.c | 10 +- plugins/data/format.c | 6 +- plugins/eval/eval.c | 4 +- plugins/example1/example1.c | 2 +- plugins/example2/example2.c | 2 +- plugins/example2/winexample2.c | 2 +- plugins/example3/example3.c | 2 +- plugins/file/file.c | 8 +- plugins/file/winfile.c | 2 +- plugins/floppy/floppy.c | 2 +- plugins/floppy/virtual-floppy.c | 8 +- plugins/floppy/virtual-floppy.h | 30 +-- plugins/full/full.c | 2 +- plugins/guestfs/guestfs-plugin.c | 2 +- plugins/info/info.c | 4 +- plugins/iso/iso.c | 5 +- plugins/libvirt/libvirt-plugin.c | 2 +- plugins/linuxdisk/linuxdisk.c | 2 +- plugins/linuxdisk/virtual-disk.h | 6 +- plugins/lua/lua.c | 2 +- plugins/memory/memory.c | 2 +- plugins/null/null.c | 2 +- plugins/ocaml/callbacks.h | 68 +++---- plugins/ocaml/plugin.c | 2 +- plugins/ocaml/plugin.h | 2 +- plugins/ondemand/ondemand.c | 2 +- plugins/partitioning/partitioning.c | 2 +- plugins/partitioning/virtual-disk.h | 8 +- plugins/pattern/pattern.c | 2 +- plugins/perl/perl.c | 32 ++-- plugins/python/modfunctions.c | 4 +- plugins/python/plugin.h | 4 +- plugins/random/random.c | 2 +- plugins/ruby/ruby.c | 4 +- plugins/sh/call.h | 6 +- plugins/sh/sh.c | 2 +- plugins/sparse-random/sparse-random.c | 4 +- plugins/split/split.c | 5 +- plugins/ssh/ssh.c | 2 +- plugins/tcl/tcl.c | 2 +- plugins/tmpdisk/tmpdisk.c | 2 +- plugins/vddk/stats.c | 10 +- plugins/vddk/vddk.c | 16 +- plugins/vddk/vddk.h | 10 +- plugins/zero/zero.c | 2 +- server/connections.c | 2 +- server/crypto.c | 2 +- server/exports.c | 2 +- server/extents.c | 6 +- server/internal.h | 98 +++++----- server/main.c | 4 +- server/protocol-handshake-newstyle.c | 2 +- server/public.c | 9 +- server/socket-activation.c | 2 +- server/sockets.c | 2 +- server/test-public.c | 2 +- server/usergroup.c | 2 +- tests/cc-shebang.c | 2 +- tests/dummy-vddk.c | 4 +- tests/test-ansi-c-plugin.c | 2 +- tests/test-disconnect-plugin.c | 2 +- tests/test-flush-plugin.c | 2 +- tests/test-layers-filter.c | 2 +- tests/test-layers-plugin.c | 2 +- tests/test-layers.c | 6 +- tests/test-read-password-plugin.c | 2 +- tests/test-shutdown-plugin.c | 2 +- tests/test-stdio-plugin.c | 2 +- tests/test.h | 4 +- tests/web-server.h | 2 +- wrapper.c | 6 +- 168 files changed, 725 insertions(+), 614 deletions(-) create mode 100644 common/include/static-assert.h base-commit: 648a7909b69ed9be576e379097da09e9507fb868