Re: [Libguestfs] [PATCH v2 5/5] v2v: update tests to match changes in OVA import

On Wed, Nov 30, 2016 at 4:44 PM, Pino Toscano <ptoscano(a)redhat.com&gt; wrote: > On Wednesday, 23 November 2016 16:40:59 CET Tomáš Golembiovský wrote: > > On Mon, 21 Nov 2016 16:41:49 +0100 > > Pino Toscano <ptoscano(a)redhat.com&gt; wrote: > > > On Saturday, 12 November 2016 16:37:53 CET Tomáš Golembiovský wrote: > > > > v2v/Makefile.am | 1 + > > > > v2v/test-v2v-i-ova-formats.sh | 5 +- > > > > v2v/test-v2v-i-ova-subfolders.expected2 | 18 +++++ > > > > v2v/test-v2v-i-ova-subfolders.sh | 12 ++- > > > > v2v/test-v2v-i-ova-tar.expected | 18 +++++ > > > > v2v/test-v2v-i-ova-tar.expected2 | 18 +++++ > > > > v2v/test-v2v-i-ova-tar.ovf | 138 > ++++++++++++++++++++++++++++++++ > > > > > > The ovf and expected files are basically copies of the -formats > > > versions -- would it be possible to reuse them? > > > > Wouldn't that be confusing? > > > > Maybe I could rename it to test-v2v-i-ova.ovf and > > test-v2v-i-ova.expected and then use it in both tests. > > Good idea. > > It turned out that there already is "test-v2v-i-ova.ovf" so renaming is not possible. Any other ideas?