Re: [Libguestfs] [PATCH 01/27] build: Make OCaml compiler required for all builds.

On Friday, 14 July 2017 15:39:09 CEST Richard W.M. Jones wrote: > Previously the OCaml compiler was only required if building from git > but was at least theoretically optional if building from tarballs > (although this was never tested). Since we want to write parts of the > daemon in OCaml, this makes OCaml required for all builds. > > Note that the ‘--disable-ocaml’ option remains, but it now only > disables OCaml bindings and OCaml virt tools. Using this option does > not disable the OCaml compiler requirement. > > Also note that ‘HAVE_OCAML’ changes meaning slightly, so it now means > "build OCaml bindings and tools" (analogous to ‘HAVE_PERL’ and > others). The generator, daemon [in a future commit], and some utility > libraries needed by the generator or daemon do not test for this macro > because we can assume OCaml compiler availability. > --- This LGTM, although i'd have taken one step further and always build all the OCaml stuff regardless (so removing --disable-ocaml, or making it show a "this is void now" message).