Re: [Libguestfs] [PATCH 2/2] launch: Add add_drive 'label' option.

On Fri, Oct 05, 2012 at 12:32:58PM +0200, Olaf Hering wrote: > No support for digits etc.? The underlying serial field supports digits and more (in fact it's really an arbitrary 20 byte buffer). However I excluded digits in this case because the usual Linux naming scheme for partitions is either: /dev/<name><partnum> where <name> ends in an alphabetic character (eg. /dev/sda) , else: /dev/<name>p<partnum> where <name> ends in a digit (eg. /dev/mmcblk0p1). If we allow people to use a label that ends in a digit then we'd (probably) need to abide by this convention too, which makes things complicated. I agree this is not ideal, but also we can relax this restriction later.