Re: [Libguestfs] [PATCH 2/2] Use 'error' function for fprintf followed by exit.

Like with the previous commit, this replaces instances of: if (something_bad) { fprintf (stderr, "%s: error message\n", guestfs_int_program_name); exit (EXIT_FAILURE); } with: if (something_bad) error (EXIT_FAILURE, 0, "error message"); (except in a few cases were errno was incorrectly being ignored, in which case I have fixed that). It's slightly more complex than the previous commit because we must be careful to: - Remove the program name (since error(3) prints it). - Remove any trailing \n character from the message. Candidates for replacement were found using: pcregrep --buffer-size 10M -M '\bfprintf\b.*\n.*\bexit\b' `git ls-files` ---

@@ -130,10 +131,8 @@ main (int argc, char *argv[]) int r; g = guestfs_create (); - if (g == NULL) { - fprintf (stderr, _("guestfs_create: failed to create handle\n")); - exit (EXIT_FAILURE); - } + if (g == NULL) + error (EXIT_FAILURE, errno, "guestfs_create");