Re: [Libguestfs] daemon/ warnings

On Mon, Aug 10, 2009 at 10:57:13AM +0200, Jim Meyering wrote: > Here are a few warning-removal changes for daemon/: > char * > -do_debug (char *subcmd, char **argv) > +do_debug (char *subcmd ATTRIBUTE_UNUSED, char **argv ATTRIBUTE_UNUSED) > { > #if ENABLE_DEBUG_COMMAND > int argc, i; Is this correct? Note that the parameters are only unused if ENABLE_DEBUG_COMMAND is not defined, but if this symbol is defined then they are used. I'm worried that gcc will try to optimize them or something. The rest of the patch is fine - ACK.