Re: [Libguestfs] [PATCH] Add Rust bindings

On Mon, Jul 08, 2019 at 10:04:57AM +0100, Richard W.M. Jones wrote: For the libnbd use-case I went with a middle ground. That is libnbd-sys is a crated with just the linkage and list of extern functions, but libnbd is supposed to just expose this as methods on the Nbd struct, which take Rust types (as opposed to C types), ensure safety and idiomatically handle errors. No other extra redesign would be there, the code handles functions that are not allowed in a particular state nicely, so that should be fine. The only thing what would be really nice to utilize in libnbd rust crate is the fact that the states there can be encoded into the way the structs are used, so that you could only call those APIs that are accessible at a current state (if that state is controllable by the client, of course), so for example you could use the builder pattern to create a handle prepared to be connected (or even connect it): let h = Nbd::new() .add_meta_context("base:allocation") .set.export_name("/") .set_debug(true) .connect_uri("nbd://") And then you would be able to do, e.g.: h.pread(); h.set_debug(false) But not: h.set_export_name("/exp"); as the object `h` would not even support that function. Anyway, even though it would be useful for libguestfs as well, thanks to the way these projects handle errors it is just something I consider "nice-to-have". Have a nice day, Martin