Re: [Libguestfs] [libnbd PATCH v4 0/2] lib/utils: introduce async-signal-safe execvpe()

On Sun, Mar 19, 2023 at 10:41:37AM +0100, Laszlo Ersek wrote: > This is version 4 of the following sub-series: > > [libnbd PATCH v3 09/29] lib/utils: introduce async-signal-safe execvpe() > [libnbd PATCH v3 10/29] lib/utils: add unit tests for async-signal-safe execvpe() > > http://mid.mail-archive.com/20230215141158.2426855-10-lersek@redhat.com > http://mid.mail-archive.com/20230215141158.2426855-11-lersek@redhat.com > > The Notes section on each patch records the updates for that patch. > > For assisting with incremental review, here's a range-diff: Thank you; the changes compared to v3 look sane, and my R-b still stands on both patches. >> ## lib/test-fork-safe-execvpe.sh (new) ## >> @@ >> @@ lib/test-fork-safe-execvpe.sh (new) >> +# License along with this library; if not, write to the Free Software >> +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA >> + >> ++. ../tests/functions.sh >> ++ >> +set -e >> + >> +# Determine the absolute pathname of the execvpe helper binary. The "realpath" >> @@ lib/test-fork-safe-execvpe.sh (new) >> + >> +# Create a temporary directory and change the working directory to it. >> +tmpd=$(mktemp -d) >> -+trap 'rm -r -- "$tmpd"' EXIT >> ++cleanup_fn rm -r -- "$tmpd" "$tmpd" probably starts with /, such that the -- is not strictly necessary; but keep it (good practice, and saves us in case someone sets $TMPDIR to an unusual relative name and mktemp does not give us a leading / after all).