Re: [Libguestfs] [PATCH v6 2/3] mllib: modify nsplit to take optional noempty and count arguments

On Tue, 31 Jan 2017 11:35:01 +0000 "Richard W.M. Jones" <rjones(a)redhat.com&gt; wrote: > On Mon, Jan 30, 2017 at 10:43:15PM +0100, Tomáš Golembiovský wrote: > > Added two new optional arguments to nsplit: > > > > * keep_empty: if set to false empty elements are not stored in the > > returned list. The default is to keep the empty elements > > The ?keep_empty flag is pointless. It's simpler and more > clear to write: > > List.filter ((<>) "") (nsplit ...) > > when you don't want empty elements. That's not entirely true when keep_empty is used in combination with count. When keep_empty is false then the split is not considered a (successful) split and internal state of count is not decreased. Example: # List.filter ((<>) "") (nsplit ~count:3 "," "a,,,b,,,c,,d" ) ;; - : string list = ["a"; "b,,,c,,d"] # nsplit ~keep_empty:false ~count:3 "," "a,,,b,,,c,,d" ;; - : string list = ["a"; "b"; "c"; ",d"]