Re: [Libguestfs] [PATCH nbdkit v2 3/3] filters: stats: Add flush stats

I have pushed some parts of these patches in order to reduce the delta between your patches and upstream. However still some problems with the series: Patch 1: Same problem with scale as discussed before. Patch 2: At least the documentation needs to be updated since it no longer matches what is printed. The idea of collecting the time taken in each operation is good on its own, so I pushed that part of it along with small const-correctness and whitespace fixes: https://github.com/libguestfs/nbdkit/commit/f280530d7d042d5e8f100125ab061... Why don't we show the total time and time / operation on each line of output (ie. per operation), instead of synthesizing the total by adding up reads and writes? Patch 3: The idea of collecting flush stats is good so I pushed that part, as well as updating the documentation: https://github.com/libguestfs/nbdkit/commit/8adf601835aee3779e278e13cae04... I omitted the "if (st->bytes > 0)" part of the patch so this shows "0 bytes" which is of course wrong but we can fix that later. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top