Re: [Libguestfs] [PATCH nbdkit] Add ssh plugin using libssh.

On 3/6/19 9:40 AM, Richard W.M. Jones wrote: Worth noting that PASSWORD cannot begin with - or +, because of: these? Is it also worth a way to read the password over an inherited file descriptor (including a pipe)? Is that a compatible license? Or I guess another way of wording it - what is the license of libssh itself? The resulting ssh plugin may already require a stronger license than what nbdkit proper allows, but the license of the .so plugin being stronger than the license of the .c files does not require the same level of care as when the license of one .c file prevents refactoring code out from there into a looser licensed .c file elsewhere. I've always found it funny to consider how "All rights reserved" is compatible with the later statements that modification rights are being granted - how can you reserve a right that you gave away? But that's not a problem with this patch (so much as a more general musing on the typical boilerplate for the BSD license), as you are faithfully copying-and-pasting a widely used pattern (that is, it's not a problem unique to nbdkit, and I don't see a reason to change that phrase in any of the existing nbdkit files or this patch without specific instructions from a legal department). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org