Re: [Libguestfs] [PATCH v3 1/6] v2v: rhv: Fix virtio-rng and memballoon OVF fragment for RHV.

On Fri, 02 Mar 2018 17:35:10 +0100 Pino Toscano <ptoscano(a)redhat.com&gt; wrote: > On Thursday, 1 March 2018 17:24:17 CET Richard W.M. Jones wrote: > > Without this extra element, oVirt will crash with a Java > > NullPointerException (see https://bugzilla.redhat.com/1550123). > > > > Fixes commit dac5fc53acdd1e51be2957c67e1e063e2132e680. > > --- > > v2v/create_ovf.ml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/v2v/create_ovf.ml b/v2v/create_ovf.ml > > index f5e34d79f..87245fdc8 100644 > > --- a/v2v/create_ovf.ml > > +++ b/v2v/create_ovf.ml > > @@ -444,6 +444,9 @@ let rec create_ovf source targets guestcaps inspect > > e "rasd:ResourceType" [] [PCData "0"]; > > e "Type" [] [PCData "rng"]; > > e "Device" [] [PCData "virtio"]; > > + e "SpecParams" [] [ > > + e "source" [] [PCData "urandom"] > > + ] > > ] > > ); > > if guestcaps.gcaps_virtio_balloon then > > @@ -454,6 +457,9 @@ let rec create_ovf source targets guestcaps inspect > > e "rasd:ResourceType" [] [PCData "0"]; > > e "Type" [] [PCData "balloon"]; > > e "Device" [] [PCData "memballoon"]; > > + e "SpecParams" [] [ > > + e "model" [] [PCData "virtio"] > > + ] > > Are they needed in both the flavours of OVF? (Not a problem for me, > just asking to understand it better.) They are needed for OVirt flavour and I assume it's needed for RHVExportDomain flavour too because of this bug: https://bugzilla.redhat.com/1550123