Re: [Libguestfs] [v2v PATCH] convert/libosinfo-c.c: turn caml_copy_*() return blocks into root values
On Tue, Jan 11, 2022 at 11:22:56AM +0000, Richard W.M. Jones wrote:
On Tue, Jan 11, 2022 at 12:15:13PM +0100, Laszlo Ersek wrote:
> By the way, we have more "offenders" left:
>
> - three in "bundled/libvirt-ocaml/libvirt_c_common.c":
I'm quite sure this happens in a lot of places.
BTW libvirt-ocaml is a separate project, so fixes should go to:
https://libvirt.org/git/?p=libvirt-ocaml.git;a=summary
(and really we should remove all bundled code - I can't recall why it
was added, but it's not needed now.)
NB that's a read-only mirror, the primary repo is:
https://gitlab.com/libvirt/libvirt-ocaml/
and takes patches via merge requests
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|