Re: [Libguestfs] [libnbd PATCH 17/20] ci: Add support for test skipping

On Tue, Jun 08, 2021 at 05:22:06PM +0100, Richard W.M. Jones wrote: I wanted to keep the build script as portable as reasonably possible. Local variable scoping looks to be available even in the most limited of shells, but there is not need for this here. It was just one thing that I learned because I've seen someone else get bitten by not using it =) This is a linear script that does not even need a function let alone any scopes. Coincidentally it is yet another thing I learned in a very similar fashion. In the meantime I added a fix/workaround for CentOS-es and fixed the FreeBSD weirdness. The only thing missing now is tests on FreeBSD, which fail a lot, and (if there is some spare time) fix up some package name mapping for MacOS. I still have one more thing that bothers me, though. The symlinks in bash/ are set to be generated and packed into the distribution (using the `dist_` prefix for `dist_bashcompdir_DATA`), but they are defined conditionally based on whether bash-completion (and libxml2) are available on the system. This, of course, breaks `make dist` for systems where any of the packages is not available. I think that there are few ways how to get out of it: 1) Remove the `dist_` prefix -- this would generate the files during build time when the availability of the dependencies is more relevant. 2) Remove the conditionals -- creating the files only relies only on `ln` to create the symlink so there is no need for the dependency to be available. 3) Remove the rules and commit the symlinks to the repository -- this would keep the symlinks in git, they would get installed based on the conditionals, but would be always available for packing into the distribution, at least that's how I understand automake. I apologise for hijacking unrelated thread for this, but I would really like your opinion on that. Have a nice day, Martin