Re: [Libguestfs] [PATCH 0/4 v1] Remove gettextify, implement OCaml gettext.
On Mon, Apr 30, 2012 at 07:43:36PM +0100, Daniel P. Berrange wrote:
On Mon, Apr 30, 2012 at 07:00:52PM +0100, Richard W.M. Jones wrote:
> Version 1 of the patch, for discussion, but not to be applied. It
> does work, but needs a lot more testing.
>
> This removes all the psychopathic gettextify cruft, and replaces it
> with a 99 line Makefile.am. A large win, I think.
That change came out very nicely indeed. I'm somewhat inclined to
kill this gettext awfulness from all the things I maintain in favour
of this approach.
Actually I think I missed out the bits so that 'make install' works.
That should only be a few more lines.
The main issue is that this would only work with GNU gettext tools,
not with gettext tools from other operating systems (ie. BSD). In
this patch I worked around that by checking that the tools are the GNU
tools and disabling NLS if not, but a better patch would work with all
gettext variants. It's not too much extra work.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org