Re: [Libguestfs] [libnbd PATCH 2/4] generator: Add RUInt64 for 64-bit counters without error

On 09/06/22 11:08, Eric Blake wrote: > On Mon, Sep 05, 2022 at 02:00:22PM +0200, Laszlo Ersek wrote: > We could further compress things to have: > > pr " debug (h, \"leave: ret=\""; > (match ret with > | RBool -> pr "%%d\", ret" > > and so on, to get rid of yet another spurious pair of "" in the > generated C code (since the return format is always exacty one > argument, there's no need to have the generated api.c have > "... ret=" "%<>" when "... ret=%<>" would do). I can touch that > up in a followup, if it makes sense. It seems to simplify the generated code (which we sometimes quote in commit messages, when patching the generator), so if it's not a big burden, I'd be in favor of it.