While working on can_FOO caching, at one point I got confused by
whether 'readonly' meant the global set by -r or a local passed to
.open(). A quick attempt to compile with -Wshadow found several other
confusing points; this series gets us to the point that we can add
-Wshadow to builds with --enable-gcc-warnings.
Eric Blake (10):
server: Avoid -Wshadow warnings
guestfs: Avoid -Wshadow warnings
ocaml: Avoid -Wshadow warnings
perl: Ignore -Wshadow warnings
ssh: Avoid -Wshadow warnings
streaming: Avoid -Wshadow warnings
tcl: Avoid -Wshadow warnings
cache: Avoid -Wshadow warnings
tests: Avoid -Wshadow warnings
maint: Enable -Wshadow during compilation
configure.ac | 2 +-
server/internal.h | 2 +-
common/bitmap/bitmap.h | 6 +++---
server/connections.c | 2 +-
server/main.c | 23 +++++++++++------------
server/protocol-handshake-newstyle.c | 7 +++----
server/protocol.c | 4 ++--
plugins/guestfs/guestfs-plugin.c | 26 +++++++++++++-------------
plugins/ocaml/ocaml.c | 2 +-
plugins/perl/perl.c | 3 +++
plugins/ssh/ssh.c | 4 ++--
plugins/streaming/streaming.c | 14 ++++++--------
plugins/tcl/tcl.c | 1 -
tests/test-exit-with-parent.c | 14 ++++++--------
tests/test-layers.c | 20 ++++++++++----------
tests/web-server.c | 6 +++---
16 files changed, 66 insertions(+), 70 deletions(-)
--
2.21.0