Re: [Libguestfs] [PATCH 2/2] firstboot: schedule firstboot as delayed task
On Thu, Feb 13, 2020 at 02:07:07PM +0100, Tomáš Golembiovský wrote:
> > I have really no clue about this.
> >
> > What is "~dpnx0"?
>
> I wanted to documented that in a comment at first. But then I decided
> against that as it seemed that as it seemed such patterns are used in
> multiple places in the code (ergo everyone knows).
>
> Looking now I see two occurrence in convert_windows.ml and one in
> firstboot.ml. I guess picking one of those for the comment should be
> enough.
>
For completeness, "~dpnx0" expands into the name of the running script
(0) with full path (p), including drive letter (d) and filename (n) with
extension (x).
You asked me on IRC about this one - sorry I wasn't reading IRC today,
trying to get some programming done :-)
Basically my position is that changes to the core firstboot
functionality (ie. in this mlcustomize module) are highly risky. I
don't claim to understand the implications of this change, and don't
have time to research or test it properly myself. I do know that we
want to change how firstboot is done (a) to make it more robust
against things like reboots that happen in the middle, (b) to allow
firstboot scripts to be prioritised in some way, and possibly
(c) to allow dependencies between firstboot scripts.
So I think there are two ways to go here:
(1) Try to make the change only in virt-v2v.
(2) Fix issues (a), (b) and (c) above, prove that it works, and submit
a patch which does all that.
Obviously (2) would be great but is a ton of work.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top