On 2/12/20 10:07 AM, Richard W.M. Jones wrote:
On Wed, Feb 12, 2020 at 09:38:29AM -0600, Eric Blake wrote:
> +#ifdef NBDKIT_INTERNAL
> +/* Opaque type encapsulating all information needed for calling into
> + * the next filter or plugin.
> + */
> +typedef struct backend backend;
> +#else
> +typedef void backend;
> +#endif
Is it better to call it something with an nbdkit_* prefix? Although
not advisable, there can be out of tree filters and we do publish
<nbdkit-filter.h> as a public header file.
Good idea. Will fix, and then push.
Anyway, you decide - ACK patch.
Rich.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization:
qemu.org |
libvirt.org