Re: [Libguestfs] [PATCH 0/6] generator: Split up generator/actions.ml

On Tue, Feb 21, 2017 at 02:47:29PM +0100, Pino Toscano wrote: > On Saturday, 18 February 2017 12:54:35 CET Richard W.M. Jones wrote: > > Split up the huge generator/actions.ml into several smaller files. > > Few notes: > > - regarding patch #2: wasn't the order stable before? Except from the > explicitly seen order change in tests_c_api.ml, what made the actions > order non-deterministic? The tests were previously ordered by something like non_daemon_functions @ daemon_functions with no sorting at all. Which was a stable order, however it's difficult to replicate that exactly in the new code because previously interleaved actions are now moved into various submodules and the submodules are concatenated.

> - regarding patch #5: I'm personally not fond of the _deprecated.ml > versions: that means in case an API is deprecated, then it is moved > from one place to another, IMHO for no reason. > +1 for the split, -1 for the _deprecated split The thinking here was to move the deprecated functions out of the way (out of sight, out of mind) for cases where we want to consider the whole modern API.

The guestfs(3) man page already hides deprecated APIs IIRC.