Re: [Libguestfs] [PATCH 0/3] Miscellaneous improvements to supermin.
On Wednesday, 7 December 2016 14:04:43 CET Richard W.M. Jones wrote:
Document what each module does, using *.mli files.
Remove the --dtb option, it's obsolete.
Rename modules according to their purpose.
Generally LGTM.
The only note is about the removal of --dtb: wouldn't it better to
leave a stub option? It would explicitly print out it was removed,
so when specified it's clearer it was not a typo but intentional
functionality drop/change.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)