Re: [Libguestfs] [PATCH 1/2] New tool: virt-tar

On 20/10/09 10:39, Richard W.M. Jones wrote: > +sub set_mode_x > +{ > + die __"virt-tar: extract/upload mode specified twice on the command > line\n" > + if $mode; > + $mode = "x"; > +} > + > +sub set_mode_u > +{ > + die __"virt-tar: extract/upload mode specified twice on the command > line\n" > + if $mode; > + $mode = "u"; > +} I'm not going to change your mind on this, am I? ;) > +# Note: 'pop' reads arguments right to left. > +my ($tarball, $directory); > +if ($mode eq "x") { > + $tarball = pop @ARGV; > + $directory = pop @ARGV; > +} else { # $mode eq "u" > + $directory = pop @ARGV; > + $tarball = pop @ARGV; > + die __"virt-tar: $tarball: file not found\n" unless -f $tarball; > +} > +die __"virt-tar: $directory: directory name must start with '/' > character\n" > + unless substr ($directory, 0, 1) eq "/"; Good call. ACK.