December 2023 - Libguestfs - libguestfs List Archives

Expect new stable releases of libguestfs, guestfs-tools, virt-v2v in January
by Richard W.M. Jones 19 Dec '23

19 Dec '23

I just released fresh development versions of libguestfs, guestfs-tools, and virt-v2v (https://download.libguestfs.org/) Despite being development versions these contain some important fixes, especially affecting OCaml 5, and they should be stable enough for production use. Since we haven't done a stable release of these packages since February 2023, I will do new stable releases in January. In the meantime please test the new development packages and let me know if there are any bugs. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top

1 0

[PATCH] daemon/btrfs: Use new syntax for balance command
by Juergen Hoetzel 14 Dec '23

14 Dec '23

Support for the obsolete short syntax 'btrfs balance /path' was removed in btrfs-progs 6.6. --- daemon/btrfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/daemon/btrfs.c b/daemon/btrfs.c index a145578b3..e6ade50d4 100644 --- a/daemon/btrfs.c +++ b/daemon/btrfs.c @@ -551,6 +551,7 @@ do_btrfs_filesystem_balance (const char *fs) ADD_ARG (argv, i, "btrfs"); ADD_ARG (argv, i, "balance"); + ADD_ARG (argv, i, "start"); ADD_ARG (argv, i, fs_buf); ADD_ARG (argv, i, NULL); -- 2.43.0

2 1

virt-builder debian-12 --update failure
by Stefan Hajnoczi 11 Dec '23

11 Dec '23

Hi, virt-builder --update debian-12 fails with: Setting up grub-pc (2.06-13+deb12u1) ... grub-pc: Running grub-install ... /dev/vda does not exist, so cannot grub-install to it! You must correct your GRUB install devices before proceeding: DEBIAN_FRONTEND=dialog dpkg --configure grub-pc dpkg --configure -a dpkg: error processing package grub-pc (--configure): installed grub-pc package post-installation script subprocess returned error exit status 1 Any idea why /dev/vda isn't available to grub-install in virt-builder? I guess there might be some special guest device configuration for the guestfs appliance that runs virt-builder steps, causing the device to appear as something other than /dev/vda. If I omit --update on the virt-builder command-line and run "dpkg-reconfigure grub-pc" inside the guest after importing with virt-install then it succeeds and /dev/vda exists. Thanks, Stefan

2 2

virt-builder debian-12 network interface naming issues
by Stefan Hajnoczi 11 Dec '23

11 Dec '23

Hi, The debian-12 template has the network interface name "ens2" in /etc/network/interfaces. After importing the disk image with virt-install I get "ens3" inside the guest. This probably happens because the libvirt domain XML is slightly different from the one that the template was generated with and the virtio-net device has a different PCI bus address. Networking does not come up after boot. One possible fix when generating the template: # cat >/etc/systemd/network/dhcp.network [Match] Name=en* [Network] DHCP=yes # systemctl enable systemd-networkd # mv /etc/network/interfaces /etc/network/interfaces.save See https://wiki.debian.org/SystemdNetworkd and https://www.debian.org/doc/manuals/debian-reference/ch05.en.html#_the_moder…. This way the image would DHCP any "ens*" network interface. I'm not sure how to best translate this into a patch, but I hope this information is useful. Having networking out-of-the-box would be nice! Thanks, Stefan

1 0

[PATCH virt-v2v 0/3] options: Allow --key all:SELECTOR
by Richard W.M. Jones 08 Dec '23

08 Dec '23

Fixes: https://issues.redhat.com/browse/RHEL-18142 This is for the common submodule. There is an associated patch which adds a new test, but that has to go into the virt-v2v repo so I'll post it separately. Rich.

2 8

[PATCH virt-v2v] tests: Test new --key all:SELECTOR option
by Richard W.M. Jones 08 Dec '23

08 Dec '23

--- common | 2 +- tests/test-v2v-fedora-luks-on-lvm-conversion.sh | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/common b/common index 6185aa84..9e988f21 160000 --- a/common +++ b/common @@ -1 +1 @@ -Subproject commit 6185aa8431b00ea3669e9e81e75233f4e865f828 +Subproject commit 9e988f21cb9ff6ace379e89ffd95ac09df8969fb diff --git a/tests/test-v2v-fedora-luks-on-lvm-conversion.sh b/tests/test-v2v-fedora-luks-on-lvm-conversion.sh index 605b19fb..09798106 100755 --- a/tests/test-v2v-fedora-luks-on-lvm-conversion.sh +++ b/tests/test-v2v-fedora-luks-on-lvm-conversion.sh @@ -35,6 +35,13 @@ keys=(--key /dev/Volume-Group/Root:key:FEDORA-Root $VG virt-v2v --debug-gc -i disk $f -o null "${keys[@]}" +keys=(--key all:key:FEDORA-Root + --key all:key:FEDORA-LV1 + --key all:key:FEDORA-LV2 + --key all:key:FEDORA-LV3) + +$VG virt-v2v --debug-gc -i disk $f -o null "${keys[@]}" + keys=(--key /dev/mapper/Volume--Group-Root:key:FEDORA-Root --key /dev/mapper/Volume--Group-Logical--Volume--1:key:FEDORA-LV1 --key /dev/mapper/Volume--Group-Logical--Volume--2:key:FEDORA-LV2 -- 2.43.0

2 2

[PATCH guestfs-tools] inspector: Test new --key all:SELECTOR option
by Richard W.M. Jones 08 Dec '23

08 Dec '23

--- common | 2 +- inspector/test-virt-inspector-luks-on-lvm.sh | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/common b/common index 6185aa84..9e988f21 160000 --- a/common +++ b/common @@ -1 +1 @@ -Subproject commit 6185aa8431b00ea3669e9e81e75233f4e865f828 +Subproject commit 9e988f21cb9ff6ace379e89ffd95ac09df8969fb diff --git a/inspector/test-virt-inspector-luks-on-lvm.sh b/inspector/test-virt-inspector-luks-on-lvm.sh index 13b25e33..349e3ed9 100755 --- a/inspector/test-virt-inspector-luks-on-lvm.sh +++ b/inspector/test-virt-inspector-luks-on-lvm.sh @@ -36,6 +36,7 @@ if [ "$(guestfish version | grep minor | awk '{print $2}')" -lt 47 ]; then fi f=../test-data/phony-guests/fedora-luks-on-lvm.img + keys=(--key /dev/Volume-Group/Root:key:FEDORA-Root --key /dev/Volume-Group/Logical-Volume-1:key:FEDORA-LV1 --key /dev/Volume-Group/Logical-Volume-2:key:FEDORA-LV2 @@ -46,6 +47,11 @@ keys_mapper=(--key /dev/mapper/Volume--Group-Root:key:FEDORA-Root --key /dev/mapper/Volume--Group-Logical--Volume--2:key:FEDORA-LV2 --key /dev/mapper/Volume--Group-Logical--Volume--3:key:FEDORA-LV3) +keys_all=(--key all:key:FEDORA-Root + --key all:key:FEDORA-LV1 + --key all:key:FEDORA-LV2 + --key all:key:FEDORA-LV3) + # Ignore zero-sized file. if [ -s "$f" ]; then uuid_root=$(guestfish --ro -i -a "$f" "${keys[@]}" \ @@ -64,4 +70,8 @@ if [ -s "$f" ]; then # virt-inspector invocation (which used the /dev/VG/LV format). $VG virt-inspector "${keys_mapper[@]}" --format=raw -a "$f" \ | diff -u "actual-$b.xml" - + + # Re-run using all:SELECTOR syntax. + $VG virt-inspector "${keys_all[@]}" --format=raw -a "$f" \ + | diff -u "actual-$b.xml" - fi -- 2.43.0

2 2

apply add kylinsecos to supermin support
by Ken Lee 07 Dec '23

07 Dec '23

Dear all: apply add kylinsecos to supermin support. Modify the code as follows, diff --git a/src/ph_rpm.ml b/src/ph_rpm.ml index 783d1bb..5061d32 100644 --- a/src/ph_rpm.ml +++ b/src/ph_rpm.ml @@ -32,12 +32,13 @@ let stringset_of_list pkgs = let fedora_detect () = Config.rpm <> "no" && Config.rpm2cpio <> "no" && rpm_is_available () && (Config.yumdownloader <> "no" || Config.dnf <> "no") && - (List.mem (Os_release.get_id ()) [ "fedora"; "rhel"; "centos"; "openEuler"; "anolis" ] || + (List.mem (Os_release.get_id ()) [ "fedora"; "rhel"; "centos"; "openEuler"; "anolis"; "KylinSecOS" ] || try (stat "/etc/redhat-release").st_kind = S_REG || (stat "/etc/fedora-release").st_kind = S_REG || (stat "/etc/openEuler-release").st_kind = S_REG || - (stat "/etc/anolis-release").st_kind = S_REG + (stat "/etc/anolis-release").st_kind = S_REG || + (stat "/etc/kylin-release").st_kind = S_REG with Unix_error _ -> false) let opensuse_detect () =

2 2