October 2022 - Libguestfs - Libguestfs List Archives

[nbdkit PATCH 0/4] Allow plugins to disconnect a single client

by Eric Blake

nbdkit_shutdown() is a harsh hammer (it kills the entire server); sometimes in testing, it is more useful to disconnect just one client while keeping the server responsive to a reconnect request. Start this by implementing a new API and putting it to use in the blocksize-policy filter. I also have a pending libnbd series that plans to make use of this feature addition in its testsuite for proving a bug-fix for libnbd not obeying qemu's 32M block_maximum sizing constraints. Still to come as followup to this: Rich and I discussed on IRC how to extend the sh/eval plugins to allow rapid-prototype testing of requesting client disconnects. The idea we came up with was defining exit status 4 (nbdkit_shutdown), 5 (nbdkit_disconnect(true)), and 6 (nbdkit_disconnect(false)) as new recognized return values from the shell scriptlets. I'd probably also change the documentation to reserve return status 7-15 as currently undefined (right now, only 7 is undefined and 8-15 are currently documented as behaving the same as exit status 1). The chance of this affecting a real client of the sh or eval plugin is minimal. Eric Blake (4): server: Switch connection status to enum server: Give client EOF when we are done writing api: Add nbdkit_disconnect(int) blocksize-policy: Add blocksize-write-disconnect=N parameter docs/nbdkit-plugin.pod | 17 ++- .../nbdkit-blocksize-policy-filter.pod | 21 +++ include/nbdkit-common.h | 3 +- tests/Makefile.am | 40 +++++- server/internal.h | 19 ++- server/connections.c | 57 ++++---- server/crypto.c | 22 +-- server/nbdkit.syms | 3 +- server/protocol.c | 107 ++++++++------- server/public.c | 15 ++- server/test-public.c | 14 +- plugins/ocaml/NBDKit.mli | 5 +- plugins/ocaml/NBDKit.ml | 1 + plugins/ocaml/bindings.c | 12 +- plugins/python/modfunctions.c | 14 ++ plugins/rust/src/lib.rs | 6 + filters/blocksize-policy/policy.c | 27 +++- tests/test-blocksize-write-disconnect.sh | 107 +++++++++++++++ tests/test-disconnect-tls.sh | 126 ++++++++++++++++++ tests/test-disconnect.sh | 100 ++++++++++++++ tests/test-disconnect-plugin.c | 95 +++++++++++++ 21 files changed, 709 insertions(+), 102 deletions(-) create mode 100755 tests/test-blocksize-write-disconnect.sh create mode 100755 tests/test-disconnect-tls.sh create mode 100755 tests/test-disconnect.sh create mode 100644 tests/test-disconnect-plugin.c -- 2.37.3

2 years

2
11
0 / 0

[libnbd PATCH 0/3] Improve nbdsh -u handling

by Eric Blake

I was trying to add a TLS test to nbdkit, and got annoyed that I couldn't just write --run 'nbdsh -u "$uri" -c ...'. This fixes the libnbd side of the problem (a URI with ?tls-psk-file=... is rejected unless we tell libnbd that parsing local files is okay); but I will also be working on patches to nbdkit ($uri is more useful if it includes 'alice@' and '?tls-psk-file=...' in the first place). Eric Blake (3): nbdsh: Refactor handling of -u and friends nbdsh: Improve --help and initial banner contents. nbdsh: Allow -u interleaved with -c python/nbdsh.py | 142 +++++++++++++++++++++++++++------------------ sh/test-context.sh | 26 ++++----- sh/test-error.sh | 37 +++++++----- 3 files changed, 119 insertions(+), 86 deletions(-) -- 2.37.3

2 years

2
7
0 / 0

libnbd | Failed pipeline for master | a96b6a79

by GitLab

Pipeline #677948894 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: a96b6a79 ( https://gitlab.com/nbdkit/libnbd/-/commit/a96b6a796856d5927333abcc344d2de... ) Commit Message: tests: Fix opt-starttls with nbdkit 1.30.10 Fe... Commit Author: Eric Blake ( https://gitlab.com/ebblake ) Pipeline #677948894 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/677948894 ) triggered by Eric Blake ( https://gitlab.com/ebblake ) had 4 failed jobs. Job #3232602727 ( https://gitlab.com/nbdkit/libnbd/-/jobs/3232602727/raw ) Stage: builds Name: x86_64-freebsd-12 Job #3232602730 ( https://gitlab.com/nbdkit/libnbd/-/jobs/3232602730/raw ) Stage: builds Name: x86_64-freebsd-13 Job #3232602745 ( https://gitlab.com/nbdkit/libnbd/-/jobs/3232602745/raw ) Stage: builds Name: x86_64-macos-11 Job #3232602734 ( https://gitlab.com/nbdkit/libnbd/-/jobs/3232602734/raw ) Stage: builds Name: x86_64-freebsd-current -- You're receiving this email because of your account on gitlab.com.

2 years

1
0
0 / 0

distutils use in hivex libdnet libnbd (and more) [was: Re: Help needed triaging build failures without distutils]

by Richard W.M. Jones

On Tue, Oct 18, 2022 at 11:27:47AM +0200, Miro Hrončok wrote: > Hey Pythonistas. > > The Python standard library distutils module will be removed from Python 3.12+ > > https://peps.python.org/pep-0632/ Annoying, but OK ... > As preparatory work, we build all python packages in a Copr repository > with Python 3.11 sans distutils: > > https://copr.fedorainfracloud.org/coprs/g/python/python-without-distutils/ > > I've rebuilt all the failed builds again and also in a control-group copr: > > https://copr.fedorainfracloud.org/coprs/g/python/python-with-distutils/ > > 250 packages that failed to build without distuils but succeeded > with distutils need to be examined and categorized into various > different groups: > > - package uses distutils only if sys.version_info < (3, 12) > -- this is OK but still fails here > - package uses distutils unconditionally and the package needs to be fixed > - package uses another package that uses distutils unconditionally > and the dependency needs to be fixed > > I suspect most of the packages will fail to build with Python 3.12 > (planned for Fedora 39, change proposal TBD). The python3-setutpools > package provides a distutils module [^1], so sometimes "simply" > adding BuildRequires: python3-setuptools might workaround the > problem. ... > rjones hivex libdnet libnbd I think your testing methodology might have been wrong because we use distutils in other packages that I maintain, notably: https://github.com/libguestfs/libguestfs/blob/master/m4/guestfs-python.m4 I'm not sure what could have happened here. The RPM would have failed to build if the Python bindings had been ./configure-d out. The link shows libguestfs as "not build yet / Disabled": https://copr.fedorainfracloud.org/coprs/g/python/python-without-distutils... but then there's a build which succeeded: https://copr.fedorainfracloud.org/coprs/g/python/python-without-distutils... and it has Python bindings. (The logs of the build don't seem to be available.) Anyway I'll see if I can fix this upstream as requested. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top

2 years

2
6
0 / 0

libnbd | Failed pipeline for master | e043adf2

by GitLab

Pipeline #673425789 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: e043adf2 ( https://gitlab.com/nbdkit/libnbd/-/commit/e043adf2823866b7efe4ba2df11a21e... ) Commit Message: build: Don't try vsock when sockaddr_vm is miss... Commit Author: Eric Blake ( https://gitlab.com/ebblake ) Pipeline #673425789 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/673425789 ) triggered by Eric Blake ( https://gitlab.com/ebblake ) had 1 failed job. Job #3209490187 ( https://gitlab.com/nbdkit/libnbd/-/jobs/3209490187/raw ) Stage: builds Name: x86_64-opensuse-leap-154-prebuilt-env -- You're receiving this email because of your account on gitlab.com.

2 years, 1 month

1
0
0 / 0

[nbdkit PATCH 00/10] Various CI improvements

by Eric Blake

2 years, 1 month

2
13
0 / 0

Why cant't use the pie link option when compiling libgustfs

by guiHua

Hello，   When I compile libgustfs, it will throw exception: undefined reference to 'caml_local_roots' when adding pie link option.  Why is that? The command is like this: ./configure CFLAGS="-O2 -fPIC" LDFLAGS="-pie -Wl". I look forward to hearing from you.

2 years, 1 month

2
1
0 / 0

[libnbd PATCH 0/2] Get back to green CI

by Eric Blake

With some help from Dan, I've managed to get back to a passing pipeline on gitlab! I'm pushing this now. Eric Blake (2): ci: Add opensuse-leap 15.4, skip TLS on 15.3 ci: Add coverage of --without-libxml2 ci/build.sh | 22 ++++++-- ci/buildenv/opensuse-leap-154.sh | 61 +++++++++++++++++++++ ci/containers/opensuse-leap-154.Dockerfile | 62 ++++++++++++++++++++++ ci/gitlab.yml | 1 + ci/gitlab/build-templates.yml | 5 ++ ci/gitlab/builds.yml | 40 ++++++++++++++ ci/gitlab/container-templates.yml | 1 + ci/gitlab/containers.yml | 7 +++ ci/manifest.yml | 15 +++++- dump/dump-data.sh | 1 + dump/dump-pattern.sh | 1 + 11 files changed, 210 insertions(+), 6 deletions(-) create mode 100644 ci/buildenv/opensuse-leap-154.sh create mode 100644 ci/containers/opensuse-leap-154.Dockerfile -- 2.37.3

2 years, 1 month

2
4
0 / 0

libnbd | Failed pipeline for master | 07b58785

by GitLab

Pipeline #671167664 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Merge request: !4 ( https://gitlab.com/nbdkit/libnbd/-/merge_requests/4 ) Commit: 07b58785 ( https://gitlab.com/nbdkit/libnbd/-/commit/07b58785f03a0ebbdb569aa44fd6aff... ) Commit Message: ci: Add opensuse-leap 15.4, skip TLS on 15.3, t... Commit Author: Eric Blake ( https://gitlab.com/ebblake ) Pipeline #671167664 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/671167664 ) triggered by Eric Blake ( https://gitlab.com/ebblake ) had 1 failed job. Job #3196991501 ( https://gitlab.com/nbdkit/libnbd/-/jobs/3196991501/raw ) Stage: builds Name: x86_64-fedora-rawhide-no-libxml2-local-env -- You're receiving this email because of your account on gitlab.com.

2 years, 1 month

1
0
0 / 0

libnbd | Failed pipeline for master | 4ae5d868

by GitLab

Pipeline #671108571 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Merge request: !4 ( https://gitlab.com/nbdkit/libnbd/-/merge_requests/4 ) Commit: 4ae5d868 ( https://gitlab.com/nbdkit/libnbd/-/commit/4ae5d8681bce1f2ad1e79dd0178de18... ) Commit Message: ci: Add opensuse-leap 15.4, skip TLS on 15.3 l... Commit Author: Eric Blake ( https://gitlab.com/ebblake ) Pipeline #671108571 ( https://gitlab.com/nbdkit/libnbd/-/pipelines/671108571 ) triggered by Eric Blake ( https://gitlab.com/ebblake ) had 1 failed job. Job #3196722889 ( https://gitlab.com/nbdkit/libnbd/-/jobs/3196722889/raw ) Stage: builds Name: x86_64-opensuse-leap-153-local-env -- You're receiving this email because of your account on gitlab.com.

2 years, 1 month

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

Libguestfs October 2022