November 2009 - Libguestfs - libguestfs List Archives

[PATCH] Fix prototype of commandv to match prototype of commandrv.
by Richard W.M. Jones 09 Nov '09

09 Nov '09

Small const-correctness patch/tidy-up. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/

2 1

[PATCH] NTFS: Invoke mkfs ntfs with -Q option.
by Richard W.M. Jones 09 Nov '09

09 Nov '09

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top

2 1

[PATCH] Add reiserfs tools to appliance.
by Richard W.M. Jones 09 Nov '09

09 Nov '09

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones New in Fedora 11: Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 70 libraries supprt'd http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw

2 2

[PATCH] appliance: Add support for btrfs, GFS, GFS2, JFS, HFS, HFS+, NILFS, OCFS2
by Richard W.M. Jones 09 Nov '09

09 Nov '09

I've tested all these filesystems here: http://rwmj.wordpress.com/2009/11/08/filesystem-metadata-overhead/ -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top

2 2

[PATCH 0/3] Three small fixes (pushed already)
by Richard W.M. Jones 09 Nov '09

09 Nov '09

I pushed these already. One seems to be an obvious fix for 32 bit platforms. The other two are tidy-ups for the OCaml bindings which won't interest most people. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora

2 1

[PATCH 0/2] Two small fixes to command*() functions in the daemon
by Richard W.M. Jones 09 Nov '09

09 Nov '09

The command*() functions are sane wrappers we use in the daemon to run external commands, and therefore very important. These two patches enhance these functions in useful ways. (Note these are an internal interface which we can change at any time). The first patch adds variations which take a flags parameter, and implements a useful flag (for dealing with parted). The second patch stops command*() from eating stderr when the stderror parameter is NULL and we're in debug mode. Currently vital logging and error information is being lost in certain circumstances, and this patch resolves this. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones New in Fedora 11: Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 70 libraries supprt'd http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw

2 5

[PATCH x 3] Three small fixes for Debian
by Richard W.M. Jones 06 Nov '09

06 Nov '09

These small fixes are required to fix the build and tests on Debian (using the debootstrap/debirf appliance). There is currently another bug in the Debian tests which I'm looking into. hexdump always fails as follows: libguestfs: error: hexdump: hexdump: /test123: hexdump: /sysroot/test123: Bad file descriptor Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones New in Fedora 11: Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 70 libraries supprt'd http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw

3 8

[PATCH] Don't update appliance after running generator.
by Richard W.M. Jones 05 Nov '09

05 Nov '09

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones New in Fedora 11: Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 70 libraries supprt'd http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw

1 0

[PATCH libguestfs] hivex: fail upon integer overflow
by Jim Meyering 04 Nov '09

04 Nov '09

This is probably only theoretical, but just the same... >From 29edcca195d2998ca4a54aacec261752a3bdeb3d Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Tue, 3 Nov 2009 18:50:23 +0100 Subject: [PATCH libguestfs] hivex: fail upon integer overflow * hivex/hivex.c (windows_utf16_to_utf8): Avoid overflow and a potential infloop. --- hivex/hivex.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hivex/hivex.c b/hivex/hivex.c index b522ccf..9c28679 100644 --- a/hivex/hivex.c +++ b/hivex/hivex.c @@ -1031,9 +1031,12 @@ windows_utf16_to_utf8 (/* const */ char *input, size_t len) size_t r = iconv (ic, &inp, &inlen, &outp, &outlen); if (r == (size_t) -1) { if (errno == E2BIG) { + size_t prev = outalloc; /* Try again with a larger output buffer. */ free (out); outalloc *= 2; + if (outalloc < prev) + return NULL goto again; } else { -- 1.6.5.2.292.g1cda2

2 1

hivex.c: unchecked calloc
by Jim Meyering 04 Nov '09

04 Nov '09

Hi Rich, There's an unchecked calloc in hivex.c's hive_open: h->bitmap = calloc (1 + h->size / 32, 1); ... This subsequent deref could cause a segfault: BITMAP_SET (h->bitmap, blkoff);

2 1