hivex.c: unchecked calloc - Libguestfs - Libguestfs List Archives

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

hivex.c: unchecked calloc

[PATCH libguestfs] hivex: fail...

[PATCH] examples/to-xml.c: Don't...

Jim Meyering

Tuesday, 3 November 2009 Tue, 3 Nov '09

11:44 a.m.

Hi Rich, There's an unchecked calloc in hivex.c's hive_open: h->bitmap = calloc (1 + h->size / 32, 1); ... This subsequent deref could cause a segfault: BITMAP_SET (h->bitmap, blkoff);

Reply

Show replies by date

Richard W.M. Jones

Wednesday, 4 November Wed, 4 Nov

5:34 a.m.

On Tue, Nov 03, 2009 at 06:44:27PM +0100, Jim Meyering wrote:

Hi Rich, There's an unchecked calloc in hivex.c's hive_open: h->bitmap = calloc (1 + h->size / 32, 1); ... This subsequent deref could cause a segfault: BITMAP_SET (h->bitmap, blkoff);

Thanks - I pushed this to fix it: http://git.et.redhat.com/?p=libguestfs.git;a=commitdiff;h=f95c697a44c321d... Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora

Reply

5478

days inactive

5479

days old

guestfs@lists.libguestfs.org

Manage subscription

1 comments

2 participants

tags (0)

participants (2)

Jim Meyering
Richard W.M. Jones