On Fri, Jan 05, 2024 at 03:26:21PM -0600, Eric Blake wrote:

Can confirm I'm able to reproduce this after updating cargo from 1.71.0 to 1.75.0. > Since the presence of async_bindings is itself conditional on tokio, > it doesn't hurt to silence that particular warning. > > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; > --- > > I don't know enough Rust to know if it would instead be better to just > delete the problematic 'pub use async_bindings::*;' line altogether; > when I did that locally, things still built and passed 'make check' > for me, but I don't know if that's because I don't have tokio > installed correctly. > > Hence, I have not pushed this yet, but will wait for a review. > > rust/src/lib.rs | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/rust/src/lib.rs b/rust/src/lib.rs > index 1e1ca2ed..6904ddad 100644 > --- a/rust/src/lib.rs > +++ b/rust/src/lib.rs > @@ -27,6 +27,7 @@ mod handle; > pub mod types; > #[allow(unused)] > mod utils; > +#[allow(unused)] > #[cfg(feature = "tokio")] > pub use async_bindings::*; > #[cfg(feature = "tokio")] > -- > 2.43.0 Looks good to me, so: Reviewed-by: Richard W.M. Jones <rjones(a)redhat.com&gt;

On Tue, Jan 09, 2024 at 03:46:56PM -0600, Eric Blake wrote: > On Tue, Jan 09, 2024 at 04:32:25PM +0000, Richard W.M. Jones wrote: > > On Fri, Jan 05, 2024 at 03:26:21PM -0600, Eric Blake wrote: > > > > > Can confirm I'm able to reproduce this after updating cargo from > > 1.71.0 to 1.75.0. > > > > > Since the presence of async_bindings is itself conditional on tokio, > > > it doesn't hurt to silence that particular warning. > > > > > > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; > > > --- > > > > > > I don't know enough Rust to know if it would instead be better to just > > > delete the problematic 'pub use async_bindings::*;' line altogether; > > > when I did that locally, things still built and passed 'make check' > > > for me, but I don't know if that's because I don't have tokio > > > installed correctly. > > > > > > Hence, I have not pushed this yet, but will wait for a review. > > > > > > rust/src/lib.rs | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/rust/src/lib.rs b/rust/src/lib.rs > > > index 1e1ca2ed..6904ddad 100644 > > > --- a/rust/src/lib.rs > > > +++ b/rust/src/lib.rs > > > @@ -27,6 +27,7 @@ mod handle; > > > pub mod types; > > > #[allow(unused)] > > > mod utils; > > > +#[allow(unused)] > > > #[cfg(feature = "tokio")] > > > pub use async_bindings::*; > > > #[cfg(feature = "tokio")] > > > -- > > > 2.43.0 > > > > Looks good to me, so: > > > > Reviewed-by: Richard W.M. Jones <rjones(a)redhat.com&gt; > > Pushed as bd44b763 There's a FreeBSD CI failure but it seems unrelated: https://gitlab.com/nbdkit/libnbd/-/jobs/5896216156 It looks like the FreeBSD 12 container that we used has gone.