Re: [Libguestfs] [PATCH 3/3] Add APIs for resolving the appliance kernel/initrd
On Tue, Jul 06, 2010 at 08:30:21AM +0100, Richard W.M. Jones wrote:
On Mon, Jul 05, 2010 at 12:26:01PM -0400, Daniel P. Berrange wrote:
> + ("get_kernel", (RConstString "kernel", []), -1, [],
RConstString is the wrong type to use here, I think.
If users should call find_appliance before this, then it should be an
error not to have called it, so RString would be the correct return
type.
Using RString introduces a needless strdup & free between
libguestfs & the caller, so I chose RConstString to avoid
this. Both RString and RConstString declare that NULL is
an error condition, so I'm not sure why we need to change
this to RString since they're appear to be equivalent in
their error reporting semantics.
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|