Re: [Libguestfs] [PATCH V3] virt-sysprep:add ipconfig for preparation
On 03/15/2012 06:37 AM, Richard W.M. Jones wrote:
On Wed, Mar 14, 2012 at 08:41:01PM +0800, Wanlong Gao wrote:
> + if [ -z $ipconfig_param ]; then
The quoting here is still (not actually) wrong, but I think
we should quote it. See my previous comment:
https://www.redhat.com/archives/libguestfs/2012-March/msg00048.html
"Apparently you don't need to quote parameters in bash, but while
this is technically correct, I think it is safer to quote it. There
are a few other similar ones later in the code."
But, if you add the right quoting, this patch will be fine and I will
push it.
Yes, I see. I didn't understand your point before.
So, I'll send a V4 with the quotes.
Thanks,
Wanlong Gao
Rich.