Re: [Libguestfs] Figuring out some failing tests for libnbd
On Wed, Jun 30, 2021 at 05:11:45PM +0200, Martin Kletzander wrote:
I am preparing more patches for CI to run check-valgrind and fix
ongoing
errors but there are two issues I can not identify the reason why they
are failing.
- On debian-10 the info/info-can.sh started failing and the error
message is just one of those I saw earlier in other places:
libnbd: debug: nbd1: nbd_opt_abort: leave: error="nbd_opt_abort:
invalid state: READY: the handle must be negotiating: Invalid
argument"
I think it is probably not the error since it happens during normal
output. The error must be something else. Is this when using
valgrind or normally? Do you have the complete log?
- On Fedora rawhide I hit a random issue where a port in a URI was
translated to its name and looking at the code I can not find how this
could have happened. Until this is fixed the test suite is unreliable
and notification fatigue will cause everyone to start ignoring any
future failures.
/builds/nertpinx/libnbd/tests/.libs/aio-connect: actual URI
nbd://127.0.0.1:altova-lm/ != expected URI nbd://127.0.0.1:35355/
That is likely a real bug. In libnbd 1.8 we added a new API which
creates the URI for connecting back to the server:
https://libguestfs.org/nbd_get_uri.3.html
When this particular test is run, the following code path is followed:
https://gitlab.com/nbdkit/libnbd/-/blob/c6109b5d37c08a430b3a55691dff72321...
which uses getnameinfo. I thought that by using NI_NUMERICHOST it
wouldn't translate the port number using /etc/services. Apparently
that's not the case.
A simple reproducer would be the one attached, except that it
segfaults :-( which means now we've got 2 bugs ...
$ nbdkit null --run './uri.py'
nbdkit: external command was killed by signal 6
The stack trace is rather long so I attached that too.
Patches welcome for both issues.
- Both openSUSE builds are failing to run check-valgrind and it
looks
like it might be unrelated to libnbd, although it would be nice for
someone else to confirm that. For now I have disabled check-valgrind
on those platforms in my branch.
What's the failure?
- Similarly to openSUSE Ubuntu 20.04 fails in valgrind tests, but
somewhere down the GnuTLS rabbit hole, which I presume is unrelated
too, so I disabled check-valgrind on that one as well.
I will send the patches once they are cleaned up, but I wanted to let
everyone know what the current status is because eliminating all random
issues is essential to properly consuming CI results.
Thanks,
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW
Attachments:
- uri-bt.txt (text/plain — 5.9 KB)
- uri.py (text/plain — 178 bytes)