Re: [Libguestfs] [PATCH v12 04/11] New API: Deprecate hivex_value_utf8 and replace with hivex_value_string.
On Wednesday, 9 August 2017 19:23:39 CEST Richard W.M. Jones wrote:
hivex has a function hivex_value_string. We were not calling it
under
the mistaken belief that because hivex implements this using iconv,
the function wouldn't work inside the daemon. Instead we
reimplemented the functionality in the library.
This commit deprecates hivex_value_utf8 and removes the library side
code. It replaces it with a plain wrapper around hivex_value_string.
Thanks: Pino Toscano
---
The only thing here is that I would leave hivex_value_utf8 as non-daemon
function, just to avoid adding an extra daemon function.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)