Re: [Libguestfs] [PATCH 1/2] v2v: rhv-upload-plugin: Handle send send failures

On Tue, Aug 21, 2018 at 2:02 PM Richard W.M. Jones <rjones(a)redhat.com&gt; wrote: > On Tue, Aug 21, 2018 at 01:15:02AM +0300, Nir Soffer wrote: > > The oVirt server may fail a PUT request before reading all request body. > > However before closing the connection, it writes a detailed error > > response, that will make debugging issues like expired tickets much > > easier to handle. If we don't get the response and log the error, the > > error may be lost when the daemon log is rotated. > > This series looks fine, I'll push it in a minute. > > Couple of questions: > > (1) Are we using the nbdkit enhanced Python error reporting yet? > What's stopping us if we are not? > In request_failed() we raise RuntimeError, so it should log a traceback, but I did not see a traceback, maybe because I did not test it in verbose mode.