Re: [Libguestfs] virt-v2v check-valgrind?
On 5/16/23 17:15, Richard W.M. Jones wrote:
Or maybe we could have tests/Makefile.am remove GLIBC_TUNABLES if
we're using valgrind. Something like this perhaps ...
check-valgrind:
- $(MAKE) VG="@VG@" check
+ $(MAKE) GLIBC_TUNABLES= VG="@VG@" check
Rich.
It requires too much work (too many patches):
==== guestfs-tools ====
align/Makefile.am: $(MAKE) VG="@VG@" check
builder/Makefile.am: $(MAKE) VG="@VG@" check
builder/templates/Makefile.am: $(MAKE) VG="@VG@" check
cat/Makefile.am: $(MAKE) VG="@VG@" check
customize/Makefile.am: $(MAKE) VG="@VG@" check
df/Makefile.am: $(MAKE) VG="@VG@" check
diff/Makefile.am: $(MAKE) VG="@VG@" check
drivers/Makefile.am: $(MAKE) VG="@VG@" check
format/Makefile.am: $(MAKE) VG="@VG@" check
inspector/Makefile.am: $(MAKE) TESTS="test-virt-inspector.sh
test-virt-inspector-luks-on-lvm.sh test-virt-inspector-lvm-on-luks.sh"
VG="@VG@" check
make-fs/Makefile.am: $(MAKE) VG="@VG@" check
resize/Makefile.am: $(MAKE) VG="@VG@" check
sparsify/Makefile.am: $(MAKE) VG="@VG@" check
sysprep/Makefile.am: $(MAKE) TESTS="test-virt-sysprep.sh" VG="@VG@"
check
==== libguestfs ====
daemon/Makefile.am: $(MAKE) VG="@VG@" check
docs/guestfs-hacking.pod: make VG="@VG@" check
docs/guestfs-hacking.pod: make VG="@VG@" check
fish/Makefile.am: $(MAKE) TESTS="test-a.sh test-add-domain.sh test-add-uri.sh
test-copy.sh test-d.sh test-edit.sh test-escapes.sh test-events.sh test-find0.sh
test-glob.sh test-inspect.sh test-prep.sh test-read-file.sh test-remote.sh
test-remote-events.sh test-reopen.sh test-run.sh test-stringlist.sh test-tilde.sh
test-upload-to-dir.sh" VG="@VG@" check
lib/Makefile.am: $(MAKE) VG="@VG@" check
lua/Makefile.am:# $(MAKE) VG="@VG@" check
ocaml/Makefile.am: $(MAKE) VG="@VG@" TESTS="$(test_progs_all)"
check
rescue/Makefile.am: $(MAKE) TESTS="test-virt-rescue-suggest.sh"
VG="@VG@" check
tests/Makefile.am: $(MAKE) VG="@VG@" check
==== libguestfs-common ====
mlcustomize/Makefile.am: $(MAKE) VG="@VG@" check
mlpcre/Makefile.am: $(MAKE) VG="@VG@" check
mlstdutils/Makefile.am: $(MAKE) VG="@VG@" check
mltools/Makefile.am: $(MAKE) VG="@VG@" check
mlvisit/Makefile.am: $(MAKE) VG="@VG@" check
qemuopts/Makefile.am: make VG="@VG@" check
==== virt-p2v ====
Makefile.am: make VG="@VG@" check
docs/p2v-hacking.pod: make VG="@VG@" check
docs/p2v-hacking.pod: make VG="@VG@" check
==== virt-v2v ====
tests/Makefile.am: $(MAKE) VG="@VG@" check
For now I'll stick with the manual "env -u".
Thanks,
Laszlo