Re: [Libguestfs] [libnbd PATCH v2 2/3] nbdsh: Allow -u interleaved with -c
On Sat, Nov 05, 2022 at 03:32:04AM +0200, Nir Soffer wrote:
On Fri, Nov 4, 2022 at 11:18 PM Eric Blake <eblake(a)redhat.com>
wrote
[...]
Sorry but I did not read, but I noticed this:
> @@ -165,7 +177,7 @@ def example(ex, desc): line("%-34s # %s" % (ex,
desc))
> line("The ‘nbd’ module has already been imported.")
> blank()
> example("h = nbd.NBD()", "Create a new handle.")
> - if args.uri is None:
> + if False: # args.uri is None:
>
If False will never run, so why not remove the entire branch?
Is this leftover from debugging?
This patch gets rid of args.uri, but the next patch tweaks the banner
to output the same message based on whether h is already connected. I
can wipe the dead code in this patch, but the example() on the next
line would then re-appear in the next patch.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org