Re: [Libguestfs] [PATCH nbdkit 2/2] vddk: Defer library initialization to .after_fork().
On 6/22/20 10:49 AM, Richard W.M. Jones wrote:
VDDK creates background threads. fork kills these, resulting in the
s/kills/strands/
library hanging or failing completely in certain configurations.
---
plugins/vddk/vddk.c | 28 ++++++++++++++++++++++------
1 file changed, 22 insertions(+), 6 deletions(-)
ACK.
Should we also modify our tests/libvixDiskLib.so dummy library to also
spawn a thread, where .pread then checks for something provided by that
helper thread, for testsuite coverage of this? That's a rather
complicated change to make, so I'm not insisting, but if you're up to
it, the more our dummy library behaves like the real thing, the harder
it is to introduce further regressions.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org