On Tue, Apr 21, 2020 at 05:07:43PM +0100, Daniel P. Berrangé wrote:
On Tue, Apr 21, 2020 at 11:44:59AM +0100, Richard W.M. Jones wrote:
> Thanks: Dan Berrangé
>
> XXX UNFINISHED:
>
> - Is using uintptr for the handle a good idea? Plugins must return
> something != 0. In other languages we would allow plugins to
> return an arbitrary object here, but this is not possible in golang
> because of lack of GC roots.
Yeah, this is the bit that looks wierd to me when thinking about this
from a Go dev POV. You asked me on IRC whether we should have a separate
interface for a connection object, and this makes me think that we should
indeed do that.
...
This is what the patch looks like with a separate connection object.
It appears to work.
Rich.
--
Richard Jones, Virtualization Group, Red Hat
http://people.redhat.com/~rjones
Read my programming and virtualization blog:
http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/