Re: [Libguestfs] [PATCH 0/5] labels: rework

-----Original Message----- From: libguestfs-bounces(a)redhat.com [mailto:libguestfs-bounces@redhat.com] On Behalf Of Pino Toscano Sent: Wednesday, July 08, 2015 4:42 PM To: libguestfs(a)redhat.com Subject: Re: [Libguestfs] [PATCH 0/5] labels: rework Hi, On Wednesday 08 July 2015 11:07:46 Chen Hanxiao wrote: > We should use the existing function from specific fs, > if not, move it to specific fs files. > > Chen Hanxiao (5): > label: move btrfslabel to btrfs.c > label: move e2label to ext2.c and call it locally > label: move ntfslabel to ntfs.c > label: use existing do_xfs_admin for xfslabel > labels: return ENOTSUP if could not set label for specific fs > > daemon/btrfs.c | 16 +++++++++++ > daemon/daemon.h | 4 +++ > daemon/ext2.c | 29 +++++++++++++++---- > daemon/labels.c | 89 ++++----------------------------------------------------- > daemon/ntfs.c | 19 ++++++++++++ > daemon/xfs.c | 7 +++++ > 6 files changed, 75 insertions(+), 89 deletions(-) Nice work! I've left easy comments on patches #2 and #5. Patches #1, #3, and #4 are okay, but I could push only #1 because the lack of #2 makes the others not apply.