Re: [Libguestfs] [PATCH v2 0/2] v2v: machine type for oVirt

On Tue, Oct 16, 2018 at 02:06:06PM +0200, Tomáš Golembiovský wrote: > On Fri, 12 Oct 2018 17:54:39 +0200 > Pino Toscano <ptoscano(a)redhat.com&gt; wrote: > > > On Friday, 12 October 2018 15:02:31 CEST Richard W.M. Jones wrote: > > > On Wed, Oct 10, 2018 at 07:25:48PM +0200, Tomáš Golembiovský wrote: > > > > changes in v2: > > > > - split patch in two > > > > - changed as per suggestions > > > > > > > > Tomáš Golembiovský (2): > > > > v2v: ovf: add firmware and machine type element > > > > v2v: enable UEFI for oVirt/RHV outputs > > > > > > > > v2v/create_ovf.ml | 12 +++++++++++- > > > > v2v/create_ovf.mli | 2 +- > > > > v2v/output_rhv.ml | 6 ++---- > > > > v2v/output_rhv_upload.ml | 4 ++-- > > > > v2v/output_vdsm.ml | 6 ++---- > > > > v2v/test-v2v-o-rhv.ovf.expected | 1 + > > > > v2v/test-v2v-o-vdsm-options.ovf.expected | 1 + > > > > 7 files changed, 20 insertions(+), 12 deletions(-) > > > > > > Patch series looks fine to me. > > > > > > Any comments Pino? If not, I'll push it. > > > > OK for me too -- if possible, please update the documentation as well > > (the "UEFI" section, in particular). > > Me or Rich? I'll fix this when I push it, later today.

Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/