Re: [Libguestfs] [PATCH v12 02/11] common: Bundle the ocaml-augeas library for use by the daemon.
On Wednesday, 9 August 2017 19:23:37 CEST Richard W.M. Jones wrote:
This commit bundles the ocaml-augeas library (upstream here:
http://git.annexia.org/?p=ocaml-augeas.git;a=summary). It's identical
to the upstream version and should remain so.
We can work towards using system ocaml-augeas, when it's more widely
available.
---
IMHO it would be better if the Augeas.Error exception had all the
available details, i.e. code, error message, minor message, and details.
Right now it does not even include any of those, so it is hard for
users to differentiate the error handling depending on the actual error.
Also, IMHO failures related to ENOMEM should caml_raise_out_of_memory().
I guess this is not doable anymore, to avoid breaking the ocaml-augeas
API? If it is doable, I'm willing to cook up a patch.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)