Re: [Libguestfs] [nbdkit PATCH] server: Reinstate limited use of -e/-exportname.
On 7/23/20 4:45 PM, Richard W.M. Jones wrote:
On Wed, Jul 22, 2020 at 12:58:07PM -0500, Eric Blake wrote:
[...]
This is fine, but there is a minor thing:
> docs/nbdkit-protocol.pod | 2 +-
In the original patch I removed this hunk from nbdkit-protocol.pod:
@@ -5,7 +5,7 @@ nbdkit - which parts of the NBD protocol nbdkit supports
=head1 SYNOPSIS
nbdkit [-n|--newstyle] [--mask-handshake MASK] [--no-sr] [-o|--oldstyle]
- [-e|--exportname EXPORTNAME] [...]
+ [...]
I guess we should add that back.
Probably not here, because -e no longer affects the protocol,
docs/nbdkit-captive.pod also has a synopsis, but it didn't cover -e
before (probably because I didn't realise that -e affected --run). So
maybe add something to that file as well?
but yes, adding mention of -e here makes sense. I'll make that change,
then push.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org