Re: [Libguestfs] [libnbd PATCH 03/20] nbdsh: Check for python-exec2c installations

On Tue, Jun 08, 2021 at 10:50:35AM +0100, Richard W.M. Jones wrote: Yes, coreutils are everywhere and the dependency is even documented in the libnbd readme, so that should not be an issue. Of course the check can be done in various ways, even just the mere presence of the wrapper could be checked with the usual `python-exec2c --version`. Come to think of it, that might actually be nicer. Well, it's not "broken", but more of a "non-standard". This is the way they made it work to have any python package installed with any python interpreter version. All the binaries and scripts are symlinks to python-exec2 and that decides whether to run python 3.6 or 3.9 (or historically 2.7 for example). For rolling distro it is a bit more complex to manage it. But that is not really the point, sorry. Anyway, it does almost the same thing as you, except it checks for which python implementation the package is installed and it does that in python (with some bells and whistles). What could actually be the best solution for this if the nbdsh.in is just changed to: #!/usr/bin/env @PYTHON@ import nbdsh nbdsh.shell() or you can also use runpy: https://docs.python.org/3/library/runpy.html We can drop this patch until we figure this out. It is not that important. But having it behave similarly to above would also remove the "non-standardiness" of nbdsh.