Re: [Libguestfs] [libnbd PATCH 02/20] interop: Do not test against broken qemu-storage-daemon
On Tue, Jun 08, 2021 at 02:59:28PM +0200, Martin Kletzander wrote:
On Tue, Jun 08, 2021 at 07:47:38AM -0500, Eric Blake wrote:
>On Tue, Jun 08, 2021 at 09:53:43AM +0200, Martin Kletzander wrote:
>>+requires_not test "$qsd_version" = "6.0.0"
>>+requires_not test "$qsd_version" = "5.1.0"
>
>Yeah, a bit ugly (especially once downstreams start shipping a variant
>of 6.0 with the patch backported), but does the job.
>
>Could we instead make it a feature check, by attempting to fire up
>qemu-storage-daemon with socket activation and checking for the known
>failure mode?
I guess so, but Rich would be the one to know whether that is testable
in some easy way or not, because the only thing I know is that these two
versions are, allegedly, broken.
I couldn't really come up with anything that would be simpler than
what Martin has proposed above.
q-s-d is not very composable :-(
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top