Re: [Libguestfs] [PATCH] Correct checks for dup failure in guestfs_launch

The use of the |= operator might seem a little off-putting at first, but when you get used to the idiom and see the general benefit of fewer branches, and not having to "goto", maybe you'll prefer it. diff --git a/src/guestfs.c b/src/guestfs.c index 0d54d65..53ef67d 100644 --- a/src/guestfs.c +++ b/src/guestfs.c @@ -1166,8 +1166,8 @@ guestfs_launch (guestfs_h *g) close (rfd[0]); int fail = 0; - fail |= dup (wfd[0]); - fail |= dup (rfd[1]); + fail |= (dup (wfd[0]) < 0); + fail |= (dup (rfd[1]) < 0); close (wfd[0]); close (rfd[1]);