Re: [Libguestfs] [PATCH 0/4] v2v: simplify driver copying from virtio-win iso
On Tue, Oct 06, 2015 at 02:12:03PM +0100, Richard W.M. Jones wrote:
On Tue, Oct 06, 2015 at 03:57:51PM +0300, Roman Kagan wrote:
> Looks right... The problem is that the statement which runs
> unconditionally is
>
> g#cp source target
>
> where, in case the condition evaluates to false, "target" is undefined,
> and "source" is anything returned from g#find vio_root, including
> directories. I thought that would case an exception one way or another,
> but it doesn't...
Something is never going to be undefined in OCaml. There's no such
thing.
I guess you mean that it would trigger a compile error; it didn't, and
it overall worked as if the parentheses were there.
OK it doesn't really matter, I'll stick in the parentheses anyway; no
point digging into OCaml peculiarities.
> I just came across another problem in the last patch of the
series,
> though: I accidentally configured libguestfs to use direct backend, and
> immediately discovered that reusing the main guestfs handle doesn't work
> with it due to the lack of support for hotplugging drives. So I'll need
> to reconsider it somehow (perhaps try with hotplug and fall back to
> creating a new handle on exception).
Why don't we just use the second handle.
Well, because it's resource-intensive and looks like an overkill for a
simple job of parsing an iso image. Not that critical, of course, and
we can drop the 4th patch altogether, if you think it's not worth while.
Roman.