Re: [Libguestfs] [PATCH] v2v: -o rhv-upload: Allow configure commands to set the Python version.

On Tuesday, 8 January 2019 13:29:47 CET Richard W.M. Jones wrote: > No functional change, but it does allow downstream distributions to > adjust the Python interpreter and nbdkit Python plugin used by > virt-v2v -o rhv-upload mode: > > ./configure --with-virt-v2v-python-interpreter=... What is the use case for this? The documentation for the variable in config.mli says: > +val virt_v2v_python_interpreter : string > +(** Return the name of the Python interpreter used to run scripts by > + [virt-v2v -o rhv-upload]. > + > + This must normally be a Python 3 interpreter. However some > + downstream distributions replace the Python 3 scripts with Python > + 2 scripts and use the following configure option to adjust this > + interpreter accordingly: > + > + [./configure --with-virt-v2v-python-interpreter=...] *) To support Python 2 way more changes are needed though, other than the interpreter, so patching one line more in python_script.ml is not a big deal in that case.

> ./configure --with-virt-v2v-nbdkit-python-plugin=... This would be OKish, although needed because of downstream changes in Fedora (where the Python plugin of nbdkit is built also as Python 3, and this version is renamed to "python3").