Re: [Libguestfs] [PATCH v2] v2v: factor out bootloader handling

On Thu, Aug 25, 2016 at 06:05:16PM +0200, Pino Toscano wrote: I checked the before and after code and I don't think anything has been missed out. My only comment is it seems a bit awkward stuffing the grub2_update_console function definition into what is effectively the class constructor. Maybe it should be hoisted to the top level of the Linux_bootloaders module (not exported, of course), or turned into a private method of the class? Anyway as this is just a quibble, ACK. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top