Re: [Libguestfs] [PATCH] renamed daemon/tsk.c to daemon/sleuthkit.c
On Wed, Mar 30, 2016 at 01:05:50PM +0200, Pino Toscano wrote:
On Tuesday 29 March 2016 22:56:29 Matteo Cafasso wrote:
> In order to support the new features I am renaming the file with a better name.
>
> The file sleuthkit.c will contain the code depending on the sleuthkit package.
>
> The original tsk.c file will contain the logic built using libtsk
> which is the sleuthkit core library.
Makes sense, pushed to git with two small changes:
> This patch is ready for review.
> Code available at:
>
> https://github.com/noxdafox/libguestfs/tree/sleuthkit_rename
(a) this part of the commit message is not needed
I asked Matteo to create this repo and link to it, since it makes it a
bit easier to keep track of the state of his patches. However as you
say it shouldn't appear in the commit message (since commit messages
are forever), but instead should be in the cover letter.
Thanks for reviewing these.
Rich.
(b) updated po/POTFILES with the file rename
Thanks,
--
Pino Toscano
_______________________________________________
Libguestfs mailing list
Libguestfs(a)redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org