Re: [Libguestfs] [nbdkit PATCH] error: Tweak filter name for easier debugging

On 02/03/22 22:29, Eric Blake wrote: > Grepping for the string 'error:' is complicated when the error filter > reports its name in the same manner. We can keep the filter .so and > file names the same, but tweak the filter .name field to change > messages using nbdkit_debug() to instead produce "error-inject:", so > that "error:" is reserved for uses of nbdkit_error(). > --- > > I confused myself while trying to debug a new libnbd today, where > injecting errors was intentional. And then I noticed that 'man > nbdkit-error-filter' already tried to warn me. But we can do one step > better, as in this patch... >

Very important patch, I'd say; log analysis is very common! Reviewed-by: Laszlo Ersek <lersek(a)redhat.com&gt;