Re: [Libguestfs] [PATCH] inspector: Fix virt-inspector on *BSD guests (RHBZ#1144138).

On Fri, Oct 06, 2017 at 09:53:27AM +0200, Pino Toscano wrote: > On Thursday, 5 October 2017 23:49:26 CEST Richard W.M. Jones wrote: > > On Thu, Oct 05, 2017 at 06:55:53PM +0200, Pino Toscano wrote: > > > On Thursday, 5 October 2017 17:36:09 CEST Richard W.M. Jones wrote: > > > > /* We need to mount everything up in order to read out the list of > > > > * applications and the icon, ie. everything below this point. > > > > + * > > > > + * XXX As a workaround for BSD guests, because the Linux kernel > > > > + * driver cannot just mount a UFS filesystem, we must disable this > > > > + * for all *BSD operating systems. We cannot read the apps or icon > > > > + * from *BSD anyway. > > > > */ > > > > > > This is not true, libguestfs can actually read those properties. The > > > proof of that is running virt-inspector with --no-applications, and > > > --no-icon shows the proper details (such as product name, mount points, > > > host name, etc) of the guest. > > > > I'm a bit confused by this comment > > I thought this was a workaround to the fact that mounting UFS partitions > can fail, without particular mount options: > > $ ./run virt-inspector -a freebsd-10.qcow2 > libguestfs: error: mount_ro: mount exited with status 32: mount: /sysroot: wrong fs type, bad option, bad superblock on /dev/sda2, missing codepage or helper program, or other error. Correct.

> I do not see why we should special-case *BSD guests, since > at most (short of fixing the re-mount issue explained above) there will > be no information extracted. This isn't correct. With this patch, instead of virt-inspector printing nothing and failing with the mount error, you get the basic information: