Re: [Libguestfs] [libnbd PATCH v5 01/12] rust: create basic Rust bindings

On Fri, Aug 11, 2023 at 08:22:34AM -0500, Eric Blake wrote: > On Thu, Aug 03, 2023 at 03:36:05PM +0000, Tage Johansson wrote: >> This commit creates basic Rust bindings in the rust directory. >> The bindings are generated by generator/Rust.ml and >> generator/RustSys.ml. >> --- >> +++ b/rust/Cargo.toml >> @@ -0,0 +1,49 @@ >> +# nbd client library in userspace >> +# Copyright Tage Johansson >> +# >> +# This library is free software; you can redistribute it and/or >> +# modify it under the terms of the GNU Lesser General Public >> +# License as published by the Free Software Foundation; either >> +# version 2 of the License, or (at your option) any later version. > This says LGPLv2+... > >> +# >> +# This library is distributed in the hope that it will be useful, >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> +# Lesser General Public License for more details. >> +# >> +# You should have received a copy of the GNU Lesser General Public >> +# License along with this library; if not, write to the Free Software >> +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA >> + >> +[workspace] >> + >> +[workspace.package] >> +authors = ["Tage Johansson"] >> +version = "0.1.0" >> +edition = "2021" >> +description = "Rust bindings for libnbd, a client library for controlling block devices over a network." >> +license = "LGPL-2.1-only" > ...but this does not. Why the discrepancy? It is a disservice to > clients to have a more restrictive license for the Rust bindings than > for the rest of libnbd. I agree with Eric that we should fix this (it seems like a simple oversight rather than a deliberate thing). If Tage you give me the OK I will change it in the upstream repo.

Rich.